Skip to content

Conversation

rli
Copy link
Contributor

@rli rli commented Jun 2, 2025

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rli rli requested review from a team as code owners June 2, 2025 20:52

if (connection != null) {
if (!connection.isSono()) {
add(actionManager.getAction("codewhisperer.switchProfiles"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep using add(QSwitchProfilesAction())?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marginally saves some GC cycles because we dont need to construct/gc

Copy link

github-actions bot commented Jun 2, 2025

Qodana Community for JVM

1 new problem were found

Inspection name Severity Problems
Unstable API Usage 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]


override fun actionPerformed(e: AnActionEvent) {
val project = e.project ?: return
currentThreadCoroutineScope().launch {

Check warning

Code scanning / QDJVMC

Unstable API Usage Warning

'currentThreadCoroutineScope()' is declared in unstable 'com.intellij.openapi.progress.CoroutinesKt' marked with @ApiStatus.Experimental
AmazonQLspService.getInstance(project).execute { lsp ->
lsp.workspaceService.executeCommand(
ExecuteCommandParams().apply {
this.command = "aws/chat/manageSubscription"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirming if this works even if auth is not migrated to Flare? Is there any step that would require regular builder id auth?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auth is not involved at all
the upgrade flow is in the browser. the flow is

extension to Flare: workspace/executeCommand (aws/chat/manageSubscription)
Flare: does some logic
Flare to extension: window/showDocument (isExternal)

@rli rli merged commit 2e70fc3 into feature/q-lsp-chat Jun 3, 2025
11 of 16 checks passed
@rli rli deleted the rli/paidtier branch June 3, 2025 18:07
rli added a commit that referenced this pull request Jun 3, 2025
rli added a commit that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants